Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardcoded rmw_gid_t length #309

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Fix hardcoded rmw_gid_t length #309

merged 1 commit into from
Mar 29, 2023

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Mar 24, 2023

This fixes the following build failure on rolling:

  error[E0308]: mismatched types
     --> src/subscription/message_info.rs:120:19
      |
  120 |             data: rmw_message_info.publisher_gid.data,
      |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an array with a fixed size of 24 elements, found one with 16 elements

@nnmm nnmm requested a review from a team March 24, 2023 20:23
@nnmm nnmm mentioned this pull request Mar 25, 2023
Merged
esteve
esteve reviewed Mar 27, 2023
View reviewed changes
rclrs/src/rcl_wrapper.h Outdated Show resolved Hide resolved
@nnmm nnmm force-pushed the rolling-gid-length branch 3 times, most recently from 589edd8 to b5fd577 Compare March 29, 2023 13:43
@nnmm nnmm merged commit 1a22b52 into main Mar 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the rolling-gid-length branch March 29, 2023 17:33
@nnmm
Copy link
Contributor Author

nnmm commented Mar 29, 2023

Thanks @esteve!

@esteve
Copy link
Collaborator

esteve commented Mar 29, 2023

@nnmm thank you for fixing this bug!

@maspe36 maspe36 mentioned this pull request Oct 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nnmm @esteve