Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Iron Irwini #319

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Add support for Iron Irwini #319

merged 1 commit into from
Jul 15, 2023

Conversation

maspe36
Copy link
Collaborator

@maspe36 maspe36 commented Jul 9, 2023

PR for #316

Changes

  • Made a new .repos file for Iron
  • Added iron as a distro in the github actions

Tested

  • colcon test
  • minimal pub/sub
  • minimal client/service/async_client
  • message_demo

Everything went pretty smooth, not sure what else we want to test

@maspe36
Copy link
Collaborator Author

maspe36 commented Jul 9, 2023

Build seems to be failing because of #320

@esteve esteve self-requested a review July 13, 2023 14:26
esteve
esteve reviewed Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maspe36 could you rebase this PR on top of main, the error in the CI should be now fixed. Thanks!

esteve
esteve approved these changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maspe36 awesome, thanks!

@esteve esteve merged commit 11b0ff4 into ros2-rust:main Jul 15, 2023
3 checks passed
@maspe36 maspe36 mentioned this pull request Oct 28, 2023
Closed
@esteve esteve mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maspe36 @esteve