Fix Mistakes in "Refactoring Of Dependency usage #387" (#387-fixup) #388

Guelakais · 2024-04-09T10:15:00Z

This commit fixes mistakes introduced in the previous "Refactoring Of Dependency usage" pull request (Refactoring Of Dependency usage #387).
I apologize for any inconvenience caused.
The main addition remains the .rustfmt.toml file, which is now correctly included in all cargo projects. This enables streamlined code formatting using cargo-fmt inside a cargo project.
The Changes inside the .rustfmt.toml are:

imports_granularity = "Crate"
array_width = 60
attr_fn_like_width = 70
brace_style = "SameLineWhere"
combine_control_expr = false
comment_width = 80
wrap_comments = true

* Set import granularity to 'Crate' for better organization. * Adjusted array width to 60 characters for readability. * Increased attribute function-like width to 70 characters. * Enabled 'SameLineWhere' brace style for consistency. * Disabled combining control expressions for clarity. * Set comment width to 80 characters. * Enabled comment wrapping to improve readability on narrow screens.

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

* Set import granularity to 'Crate' for better organization. * Adjusted array width to 60 characters for readability. * Increased attribute function-like width to 70 characters. * Enabled 'SameLineWhere' brace style for consistency. * Disabled combining control expressions for clarity. * Set comment width to 80 characters. * Enabled comment wrapping to improve readability on narrow screens.

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

* Set import granularity to 'Crate' for better organization. * Adjusted array width to 60 characters for readability. * Increased attribute function-like width to 70 characters. * Enabled 'SameLineWhere' brace style for consistency. * Disabled combining control expressions for clarity. * Set comment width to 80 characters. * Enabled comment wrapping to improve readability on narrow screens.

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Guelakais · 2024-04-09T10:27:27Z

By the way, watching the test process is quite exciting. How can you do the same thing that your test process does locally?

mxgrey · 2024-04-09T10:48:22Z

Sorry to be picky, but I have a few concerns to consider:

rustfmt will search recursively through parent directories to find a .rustfmt.toml file, so we don't need to add the file to each package. We can just have one .rustfmt.toml file at the root of the repository. I just checked locally that this works as expected. We should prefer one style configuration file for the whole project so that if there is ever a decision to modify the style in the future, we can do that easily in one file.
In the working group there was a consensus on merging imports, but that was the only style change discussed. I don't think it's a good idea to introduce other style changes without checking on how the group feels. It will be a month until the next meeting, but we could drop a message in the matrix chat.
After testing locally, I discovered that almost all of the style settings are currently unstable, which means they require the nightly channel in order for rustfmt to actually use them. This means we won't actually be able to enforce these style settings through CI for now, which is disappointing. There's nothing we can do about this point, I'm just stating an observation.

esteve · 2024-04-09T11:25:28Z

Superseded by #389

* adde .rustfmt.toml to main repository folder * added rust_formatter.sh * added content to the rust_formatter.sh * removed rust_formatter.sh for better performance * modechange * Run rustfmt Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` * Run rustfmt Does change the things described in the newly added `.rustfmt.toml` --------- Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> Co-authored-by: GueLaKais <koroyeldores@gmail.com>

GueLaKais added 30 commits April 9, 2024 11:48

Update code formatting configuration through .rustfmt.toml

5466d47

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

2258772

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

f8bb31a

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

face334

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

b516f4c

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

5718298

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

1c1e2eb

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

18ed6b7

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

47b1b91

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

168de96

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

e1a9513

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

5bab99f

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

2d07d63

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

ca64f36

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

9331899

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

08b84db

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

b343904

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

5a00770

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

22f8fed

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

f7cd342

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

b5d109f

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

824d738

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

56945f3

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

6b15b3a

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

290a7a5

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

9556774

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

651dbb1

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

3263dc9

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

5937912

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

GueLaKais added 11 commits April 9, 2024 11:54

Update code formatting configuration through .rustfmt.toml

86a85fb

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

cb191a9

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

bc10cea

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

ce6a7ba

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

f614676

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

61240d5

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

b1968ef

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Update code formatting configuration through .rustfmt.toml

6efcd0b

This commit updates the code formatting configuration for this project. Refer to the project-specific `.rustfmt.toml` file (located alongside Cargo.toml) for details on the specific formatting changes made.

Guelakais closed this by deleting the head repository Apr 9, 2024

esteve mentioned this pull request Apr 9, 2024

Fixup of #388 #389

Merged

ros2-rust-release-plz bot mentioned this pull request Aug 15, 2025

chore: release v0.5.0 #511

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Mistakes in "Refactoring Of Dependency usage #387" (#387-fixup) #388

Fix Mistakes in "Refactoring Of Dependency usage #387" (#387-fixup) #388

Uh oh!

Guelakais commented Apr 9, 2024

Uh oh!

Guelakais commented Apr 9, 2024

Uh oh!

mxgrey commented Apr 9, 2024 •

edited

Loading

Uh oh!

esteve commented Apr 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix Mistakes in "Refactoring Of Dependency usage #387" (#387-fixup) #388

Fix Mistakes in "Refactoring Of Dependency usage #387" (#387-fixup) #388

Uh oh!

Conversation

Guelakais commented Apr 9, 2024

Uh oh!

Guelakais commented Apr 9, 2024

Uh oh!

mxgrey commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

esteve commented Apr 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mxgrey commented Apr 9, 2024 •

edited

Loading