Bumb bindgen dependency to 0.70 #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
|
Incidentally this also brings the number of built crates for |
mxgrey
approved these changes
Dec 23, 2024
esteve
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
@luca-della-vedova this is the cleanest solution in my opinion, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #451, fixes #449.
It turns out
bindgenfully dropped thewhichdependency that caused the issue in the first place in 0.70 in this PR.We can just avoid the issue altogether by bumping
bindgen. Why not 0.71? Because I encountered a build error due to an outdated lock file that would be fixed by this PR that is however not released. If we were to bump to 0.71 users that have a semi-old lockfile will have a failing build.My proposal would be, once that PR is released, to update to the version with it (most likely a 0.71.2).
Migration
The one line code diff addresses a deprecated API. Note however that it is a behavior change as noted here. The new behavior looked sensible but we can just set it to false if we want to be extra conservative