-
Notifications
You must be signed in to change notification settings - Fork 175
first fetch and rebase branch before PR #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@knmcguire thanks. Is this ready for review or are you going to work more on it? |
|
@esteve if it looks good to you you can go ahead and merge. Won't have time to add any of the improvements that I had in mind but this will fix the CI issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hmmm... I don't think i fixed the issue though? |
|
@knmcguire the changes generated by the generate bindings workflow should be committed before rebasing this is the error we got: |
|
ahh... yes I see the issue now. Let me fix this in a new PR |
|
@knmcguire awesome, thank you 🙏 |
The CI for creating bindings fails because of this:
I've added a fetch and rebase to the yml. But I might add some more improvements as well so I'll keep it in draft