Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force reinstall dependencies if using venv #234

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Jan 3, 2019

If asked to use a virtual environment then force reinstall all packages in the virtual env. This makes sure vcs is installed there even if it is also installed system wide.

Fixes #233

@sloretz sloretz added the in review Waiting for review (Kanban column) label Jan 3, 2019
@sloretz sloretz self-assigned this Jan 3, 2019
@sloretz
Copy link
Contributor Author

sloretz commented Jan 3, 2019

CI
Build Status

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sloretz sloretz merged commit ec3050a into master Jan 3, 2019
@sloretz sloretz deleted the vcs_issue_233 branch January 3, 2019 19:31
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Jan 3, 2019
@tfoote
Copy link
Contributor

tfoote commented Jan 3, 2019

Taking a look at this if we're getting interference from the system version do we really want to use the system-site-package added in #216? @dirk-thomas is it not possible to use the venv only when doing the rqt stuff? It seems like if the compiled elements are there there should be python packages that can take advantage of the compiled elements from the system from inside the venv.

@dirk-thomas
Copy link
Member

is it not possible to use the venv only when doing the rqt stuff?

It didn't work when we tried it since some of the Python packages are coming from Debian packages and are not found when not using --system-site-packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants