temporary hack to keep logs on Windows #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
reviewed
Jan 25, 2019
dirk-thomas
force-pushed
the
keep_logs_windows
branch
from
354ce10 to
3411e13
Compare
sloretz
approved these changes
Jan 25, 2019
|
Reconfigured all Windows jobs. There is actually a second location which deletes the workspace: 23bd5c3 disables that one too. |
|
Windows is picky about deleting files with |
|
Independent of this change I found and fixed another logic error which wasn't triggered before: eb7d331 |
dirk-thomas
added a commit
that referenced
this pull request
Jan 25, 2019
This was referenced Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To debug ros2/build_farmer#161.
Should be reverted later.