Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros-ROS1_DISTRO-xmlrpcpp install #669

Closed
wants to merge 1 commit into from

Conversation

methylDragon
Copy link

@methylDragon methylDragon commented Jun 23, 2022

The merge of ros2/ros1_bridge#331 adds a new dependency to ros1_bridge: xmlrpcpp.
I've seen some packaging jobs that pass despite not having this, but I think it's safer to include it?

So this just adds a rule to install the ros-${ROS1_DISTRO}-xmlrpcpp package, which exists across a ton of ROS1 distributions.

image

Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Author

methylDragon commented Jun 24, 2022

Example:

  • Without this branch: Build Status
  • With this branch: Build Status

@methylDragon
Copy link
Author

Oh no..

@methylDragon methylDragon marked this pull request as draft June 24, 2022 00:32
@methylDragon
Copy link
Author

Okay, I think jammy isn't supposed to work anyway, I'll close this (for now)

@clalancette clalancette deleted the ch3/fix_ros1_bridge_dependencies branch September 3, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant