Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ready_fn with ReadyToTest action #404

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Replace ready_fn with ReadyToTest action #404

merged 1 commit into from
Oct 21, 2019

Conversation

pbaughman
Copy link
Contributor

The ready_fn will be deprecated in the future in favor of the ReadyToTest() action in launch_testing. See ros2/launch#346 (comment) for background information

Signed-off-by: Pete Baughman pete.baughman@apex.ai

Replace ready_fn with ReadyToTest action
6b4b170 
Signed-off-by: Pete Baughman <pete.baughman@apex.ai>
@pbaughman pbaughman mentioned this pull request Oct 21, 2019
Merged
@sloretz
Copy link
Contributor

sloretz commented Oct 21, 2019 •
edited
Loading

CI (Shared with ros2/rcutils#184, testing rcutils composition demo_nodes_cpp demo_nodes_cpp_native image_tools intra_process_demo lifecycle logging_demo pendulum_control)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

sloretz
sloretz approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and CI is green

@sloretz sloretz merged commit bf679d7 into ros2:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbaughman @sloretz @mjcarroll