-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matched event demo for rclcpp and rclpy #607
Changes from 2 commits
fbe800e
ea480d8
334a2ca
b93de93
47d293f
9a9aa4e
1f97ec7
21b3bf1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,223 @@ | ||
// Copyright 2023 Sony Group Corporation. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
#include <chrono> | ||
#include <string> | ||
#include <vector> | ||
|
||
#include "rclcpp/rclcpp.hpp" | ||
|
||
#include "std_msgs/msg/string.hpp" | ||
|
||
#include "demo_nodes_cpp/visibility_control.h" | ||
|
||
using namespace std::chrono_literals; | ||
|
||
// This demo program shows matched event work. | ||
// Matched event occurs when publisher and subscription establishes the connection. | ||
// Class MatchedEventDetectNode output connection information of publisher and subscription. | ||
// Class MultiSubNode is used to create/destroy subscription to connect/disconnect the publisher of | ||
// MatchedEventDetectNode. | ||
// Class MultiPubNode is used to created/destroy publisher to connect/disconnect the subscription | ||
// of MatchedEventDetectNode. | ||
|
||
class MatchedEventDetectNode : public rclcpp::Node | ||
{ | ||
public: | ||
DEMO_NODES_CPP_PUBLIC explicit MatchedEventDetectNode( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If using the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. |
||
const std::string & pub_topic_name, | ||
const std::string & sub_topic_name) | ||
: Node("matched_event_detect_node") | ||
{ | ||
rclcpp::PublisherOptions pub_options; | ||
pub_options.event_callbacks.matched_callback = | ||
[this](rclcpp::MatchedInfo & s) { | ||
if (any_subscription_connected_) { | ||
if (s.current_count == 0) { | ||
RCLCPP_INFO(this->get_logger(), "Last subscription is disconnected."); | ||
any_subscription_connected_ = false; | ||
} else { | ||
RCLCPP_INFO( | ||
this->get_logger(), | ||
"The changed number of connected subscription is %d and current number of connected" | ||
" subscription is %lu.", s.current_count_change, s.current_count); | ||
} | ||
} else { | ||
if (s.current_count != 0) { | ||
RCLCPP_INFO(this->get_logger(), "First subscription is connected."); | ||
any_subscription_connected_ = true; | ||
} | ||
} | ||
}; | ||
|
||
pub_ = create_publisher<std_msgs::msg::String>( | ||
pub_topic_name, 10, pub_options); | ||
|
||
rclcpp::SubscriptionOptions sub_options; | ||
sub_options.event_callbacks.matched_callback = | ||
[this](rclcpp::MatchedInfo & s) { | ||
if (any_publisher_connected_) { | ||
if (s.current_count == 0) { | ||
RCLCPP_INFO(this->get_logger(), "Last publisher is disconnected."); | ||
any_publisher_connected_ = false; | ||
} else { | ||
RCLCPP_INFO( | ||
this->get_logger(), | ||
"The changed number of connected publisher is %d and Current number of connected" | ||
" publisher is %lu.", s.current_count_change, s.current_count); | ||
} | ||
} else { | ||
if (s.current_count != 0) { | ||
RCLCPP_INFO(this->get_logger(), "First publisher is connected."); | ||
any_publisher_connected_ = true; | ||
} | ||
} | ||
}; | ||
sub_ = create_subscription<std_msgs::msg::String>( | ||
sub_topic_name, | ||
10, | ||
[](std_msgs::msg::String::ConstSharedPtr) {}, | ||
sub_options); | ||
} | ||
|
||
private: | ||
rclcpp::Publisher<std_msgs::msg::String>::SharedPtr pub_; | ||
rclcpp::Subscription<std_msgs::msg::String>::SharedPtr sub_; | ||
bool any_subscription_connected_{false}; | ||
bool any_publisher_connected_{false}; | ||
}; | ||
|
||
class MultiSubNode : public rclcpp::Node | ||
{ | ||
public: | ||
DEMO_NODES_CPP_PUBLIC explicit MultiSubNode(const std::string & topic_name) | ||
: Node("multi_sub_node"), | ||
topic_name_(topic_name) | ||
{} | ||
|
||
DEMO_NODES_CPP_PUBLIC void create_one_sub(void) | ||
{ | ||
auto sub = create_subscription<std_msgs::msg::String>( | ||
topic_name_, | ||
10, | ||
[](std_msgs::msg::String::ConstSharedPtr) {}); | ||
subs_.emplace_back(sub); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's better to output an info message that there is a subscription coming, which will make the whole output a little more clear. ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay. |
||
} | ||
|
||
DEMO_NODES_CPP_PUBLIC void destroy_one_sub(void) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even if it's a demo that we can control the whole process, I think we should design a better behavior in this method. It's just a suggestion,
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you means test as the below auto sub1 = multi_sub_node->create_one_sub();
executor.spin_some(200ms);
auto sub2 = multi_sub_node->create_one_sub();
executor.spin_some(200ms);
multi_sub_node->destroy_one_sub(sub1);
executor.spin_some(200ms);
multi_sub_node->destroy_one_sub(sub2);
executor.spin_some(200ms); There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. |
||
{ | ||
subs_.erase(subs_.begin()); | ||
} | ||
|
||
private: | ||
std::string topic_name_; | ||
std::vector<rclcpp::Subscription<std_msgs::msg::String>::SharedPtr> subs_; | ||
}; | ||
|
||
class MultiPubNode : public rclcpp::Node | ||
{ | ||
public: | ||
DEMO_NODES_CPP_PUBLIC explicit MultiPubNode(const std::string & topic_name) | ||
: Node("multi_pub_node"), | ||
topic_name_(topic_name) | ||
{} | ||
|
||
DEMO_NODES_CPP_PUBLIC void create_one_pub(void) | ||
{ | ||
auto pub = create_publisher<std_msgs::msg::String>(topic_name_, 10); | ||
pubs_.emplace_back(pub); | ||
} | ||
|
||
DEMO_NODES_CPP_PUBLIC void destroy_one_pub(void) | ||
{ | ||
pubs_.erase(pubs_.begin()); | ||
} | ||
|
||
private: | ||
std::string topic_name_; | ||
std::vector<rclcpp::Publisher<std_msgs::msg::String>::SharedPtr> pubs_; | ||
}; | ||
|
||
int main(int argc, char ** argv) | ||
{ | ||
setvbuf(stdout, NULL, _IONBF, BUFSIZ); | ||
rclcpp::init(argc, argv); | ||
|
||
std::string topic_name_for_detect_pub_matched_event = "pub_topic_matched_event_detect"; | ||
std::string topic_name_for_detect_sub_matched_event = "sub_topic_matched_event_detect"; | ||
|
||
rclcpp::executors::SingleThreadedExecutor executor; | ||
|
||
auto matched_event_detect_node = std::make_shared<MatchedEventDetectNode>( | ||
topic_name_for_detect_pub_matched_event, | ||
topic_name_for_detect_sub_matched_event); | ||
|
||
auto multi_sub_node = std::make_shared<MultiSubNode>( | ||
topic_name_for_detect_pub_matched_event); | ||
|
||
auto multi_pub_node = std::make_shared<MultiPubNode>( | ||
topic_name_for_detect_sub_matched_event); | ||
|
||
executor.add_node(matched_event_detect_node); | ||
executor.add_node(multi_sub_node); | ||
executor.add_node(multi_pub_node); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// First subscription is connected. | ||
multi_sub_node->create_one_sub(); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// The changed number of connected subscription is 1 and current number of connected subscription | ||
// is 2. | ||
multi_sub_node->create_one_sub(); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// The changed number of connected subscription is -1 and current number of connected subscription | ||
// is 1. | ||
multi_sub_node->destroy_one_sub(); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// Last subscription is disconnected. | ||
multi_sub_node->destroy_one_sub(); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// First publisher is connected. | ||
multi_pub_node->create_one_pub(); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// The changed number of connected publisher is 1 and Current number of connected publisher | ||
// is 2. | ||
multi_pub_node->create_one_pub(); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// The changed number of connected publisher is -1 and Current number of connected publisher | ||
// is 1. | ||
multi_pub_node->destroy_one_pub(); | ||
executor.spin_some(200ms); | ||
|
||
// MatchedEventDetectNode will output: | ||
// Last publisher is disconnected. | ||
multi_pub_node->destroy_one_pub(); | ||
executor.spin_some(200ms); | ||
|
||
rclcpp::shutdown(); | ||
return 0; | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,8 @@ | ||||||
First subscription is connected. | ||||||
The changed number of connected subscription is 1 and current number of connected subscription is 2. | ||||||
The changed number of connected subscription is -1 and current number of connected subscription is 1. | ||||||
Last subscription is disconnected. | ||||||
First publisher is connected. | ||||||
The changed number of connected publisher is 1 and Current number of connected publisher is 2. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
please update |
||||||
The changed number of connected publisher is -1 and Current number of connected publisher is 1. | ||||||
Last publisher is disconnected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it if not to build the following classes into a library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Should remove it.
Thanks.