Migrate std::bind calls to lambda expressions #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felipe Gomes de Melo <felipegmelo.42@gmail.com>
Signed-off-by: Felipe Gomes de Melo <felipegmelo.42@gmail.com>
Signed-off-by: Felipe Gomes de Melo <felipegmelo.42@gmail.com>
Signed-off-by: Felipe Gomes de Melo <felipegmelo.42@gmail.com>
Signed-off-by: Felipe Gomes de Melo <felipegmelo.42@gmail.com>
Signed-off-by: Felipe Gomes de Melo <felipegmelo.42@gmail.com>
FelipeGdM
requested review from
adityapande-1995,
audrow and
mjeronimo
as code owners
Signed-off-by: Felipe Gomes de Melo <felipegmelo.42@gmail.com>
fujitatomoya
approved these changes
Dec 14, 2023
|
@tylerjw could you do another review for this? @FelipeGdM after this PR is merged, we can get back to ros2/ros2_documentation#4041 to make sure if everything aligns with this PR. |
|
@tylerjw to review |
|
CI (repos build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up from the work done in the documentation ros2/ros2_documentation#4041
This PR migrates the C++ examples that use std::bind to equivalent lambda expression code