Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format+example for adding year+last modified year for each article #322

Merged

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Sep 30, 2021

Closes #320

The goal is to include a "date written" and possibly a "last modified" YYYY-MM date to each article. The latter is optional and only intended for somewhat significant changes, not typo fixes. I could remove it if it's not deemed to be that important.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
articles/010_why_ros2.md Outdated Show resolved Hide resolved
articles/010_why_ros2.md Outdated Show resolved Hide resolved
@clalancette
Copy link
Contributor

Also, I should say: thanks for kicking this off!

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am good to go with this.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for starting this. @ros2/team any additional comments here?

I don't think we should merge this until we've gotten dates on pretty much everything here. I can volunteer to do at least some of the articles; I'll work on that this afternoon a bit.

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor

All right, I went through and added the date for every article in 32634db . Please take a look when you get a chance.

@christophebedard
Copy link
Member Author

I haven't checked all the dates, but it looks good!

In the future, it'd be nice to extract some of that repetitive template stuff out into a "post" layout.

@clalancette
Copy link
Contributor

Even though I did a bunch of work on this, I've still approved it and I'm going to go ahead and merge. Thanks again @christophebedard !

@clalancette clalancette merged commit 12f61b1 into ros2:gh-pages Oct 1, 2021
@christophebedard christophebedard deleted the add-date-format-for-articles branch October 1, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can we add a "date written" to the design docs?
4 participants