Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifecycle node support for tf2_ros::Buffer #580

Closed
rasmusan opened this issue Jan 24, 2023 · 0 comments · Fixed by #656
Closed

Lifecycle node support for tf2_ros::Buffer #580

rasmusan opened this issue Jan 24, 2023 · 0 comments · Fixed by #656

Comments

@rasmusan
Copy link

rasmusan commented Jan 24, 2023 •
edited
Loading

Feature request

Feature description

Similar to #70, #94, and #95, the Buffer class needs support for lifecycle nodes.

When working with lifecycle nodes, the missing support causes logs from the Buffer to be unavailable on /rosout. Also, the service "tf2_frames" is not available.

Implementation considerations

The Buffer constructor could take a templated node reference, similar to StaticTransformBroadcaster.

I could write up a PR, if such a solution could be accepted?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding NodeInterfaces to Buffer CursedRock17/geometry2
1 participant
@rasmusan