Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LifecycleNode support for tf2_ros::TransformListener #94

Closed
mjeronimo opened this issue Mar 4, 2019 · 4 comments
Closed

LifecycleNode support for tf2_ros::TransformListener #94

mjeronimo opened this issue Mar 4, 2019 · 4 comments
Labels
backlog enhancement New feature or request

Comments

@mjeronimo
Copy link

mjeronimo commented Mar 4, 2019

Feature request

Feature description

Similar to #70, the TransformListener class needs support for lifecycle nodes.

Implementation considerations

There could be a constructor that takes the required node interfaces, perhaps in addition to rclcpp::Node and rclcpp_lifecycle::LifecycleNode.

@mjeronimo
Copy link
Author

@wjwwood @tfoote I'd like to update the TransformListener class to work with interface pointers rather than rclcpp::Node::SharedPtr so that it can work with lifecycle nodes. However, it's not clear to me how one would use the node_topics interface to create a subscription. It requires a subscription factory and subscription options from the RCL layer. I can't seem to untangle this. Can you provide some guidance on how this should be done? Thanks.

@kurshakuz
Copy link
Contributor

I believe that issue was fixed in #108

@DLu
Copy link

DLu commented Aug 8, 2022

@mjeronimo Can this be closed?

@mjeronimo
Copy link
Author

@DLu Yes, thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants