Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on orocos_kdl_vendor #473

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Depend on orocos_kdl_vendor #473

merged 2 commits into from
Apr 4, 2022

Conversation

jacobperron
Copy link
Member

@jacobperron jacobperron commented Oct 28, 2021

  • Change package.xml dependency to the vendor package
  • Add missing include directories for orocos_kdl
  • Install tf2_kdl as a header-only target

Connects to ros2/ros2#1208

@jacobperron jacobperron self-assigned this Oct 28, 2021
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 7ba8e93 to 33b917b Compare January 6, 2022 23:41
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 33b917b to 6df4941 Compare February 24, 2022 04:51
@jacobperron jacobperron changed the title Fix linking against orocos-kdl Depend on orocos_kdl_vendor Feb 24, 2022
@jacobperron jacobperron marked this pull request as ready for review February 24, 2022 05:05
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 6df4941 to 0114d09 Compare March 31, 2022 23:33
* Change package.xml dependency to the vendor package
* Add missing include directories for orocos_kdl
  Upstream should probably be updated to use modern cmake targets.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron force-pushed the jacob/upstream_orocos_kdl branch from 0114d09 to ebedf3c Compare April 1, 2022 20:42
Same as #506, but in a different file
where Eigen headers are being included.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

I had to add 8d79ded to quiet compiler warnings coming from Eigen headers.

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron jacobperron merged commit ea5b008 into ros2 Apr 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/upstream_orocos_kdl branch April 4, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants