Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the time_jump_callback signature. #711

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Fix the time_jump_callback signature. #711

merged 1 commit into from
Oct 4, 2024

Conversation

clalancette
Copy link
Contributor

Because it accesses object data, the first argument must be 'self'.

This should fix #710

@clalancette
Fix the time_jump_callback signature.
5b337f9 
Because it accesses object data, the first argument
must be 'self'.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette mentioned this pull request Oct 3, 2024
Closed
@clalancette
Copy link
Contributor Author

@ottojo it would be helpful if you could test this out and report on whether it fixes the issue for you.

@ottojo
Copy link

ottojo commented Oct 3, 2024 •
edited
Loading

@ottojo it would be helpful if you could test this out and report on whether it fixes the issue for you.

this fixes the problem all the way to rqt-tf-tree in jazzy! now i get

[WARN] [1727982819.603705139] [tf2_buffer]: Detected jump back in time. Clearing tf buffer.

when without the fix rqt would crash, as expected.

thanks for the quick fix!

@clalancette
Copy link
Contributor Author

thanks for the quick fix!

That is all @sloretz looking into it: I just typed "self" in my editor :).

In any case, thanks for the quick test. I'll run CI on this, and assuming that is successful merge it and backport it to Jazzy.

@clalancette
Copy link
Contributor Author

Pulls: #711
Gist: https://gist.githubusercontent.com/clalancette/62b268b1728630fd52a7f87c87408a16/raw/8f6226d64d310487f277fc9ed6364e93ef2fa148/ros2.repos
BUILD args: --packages-above-and-dependencies tf2_ros_py
TEST args: --packages-above tf2_ros_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14655

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit efc7845 into rolling Oct 4, 2024
2 checks passed
@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

https://github.com/Mergifyio backport jazzy

@ahcorde ahcorde deleted the clalancette/fix-time-jump-callback branch October 4, 2024 07:52
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 4, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 4, 2024
@clalancette @mergify
Fix the time_jump_callback signature. (#711)
be03019 
Because it accesses object data, the first argument
must be 'self'.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit efc7845)
@mergify mergify bot mentioned this pull request Oct 4, 2024
Merged
ahcorde pushed a commit that referenced this pull request Oct 4, 2024
@mergify @clalancette
Fix the time_jump_callback signature. (#711) (#712)
646342c 
Because it accesses object data, the first argument
must be 'self'.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit efc7845)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

time jump post_callback called with wrong number of arguments
4 participants
@clalancette @ottojo @ahcorde @sloretz