Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ROS specific launch packages which were moved to ros2/launch_ros #211

Merged
merged 1 commit into from
Mar 22, 2019
Merged

remove ROS specific launch packages which were moved to ros2/launch_ros #211

merged 1 commit into from
Mar 22, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Mar 21, 2019

Connects to ros2/launch_ros#1

@wjwwood
remove all ROS specific launch packages which are being moved to ros2…
999009d 
…/launch_ros

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood self-assigned this Mar 21, 2019
@wjwwood wjwwood requested a review from hidmic March 21, 2019 19:12
@wjwwood wjwwood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Mar 21, 2019
@wjwwood wjwwood mentioned this pull request Mar 21, 2019
Closed
29 tasks
hidmic
hidmic approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic mentioned this pull request Mar 21, 2019
Merged
@hidmic
Copy link
Contributor

hidmic commented Mar 21, 2019

CI (full run):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic merged commit abaa861 into master Mar 22, 2019
@hidmic hidmic removed the in review Waiting for review (Kanban column) label Mar 22, 2019
@hidmic hidmic deleted the import_from_launch branch March 22, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@wjwwood wjwwood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjwwood @hidmic