Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RegisterEventHandler describe its sub-entities #386

Conversation

pbaughman
Copy link
Contributor

  • Make the RegisterEventHandler action return a description of its conditional sub-entities
  • Also wire up the correct description method for the launch_testing
    stdout ready listener event handler

This is needed so that launch_testing can find a ReadyToTest action that's conditional on seeing some stdout from one of the processes under test

Signed-off-by: Pete Baughman peter.c.baughman@gmail.com

  • Closes issue 385

  - Also wire up the correct description method for the launch_testing
stdout ready listener event handler

Signed-off-by: Pete Baughman <peter.c.baughman@gmail.com>
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Can you add a test case?

@pbaughman
Copy link
Contributor Author

@ivanpauno

Can you add a test case?

Yes! let me put a little thought into it first though.

Signed-off-by: Pete Baughman <peter.c.baughman@gmail.com>
@pbaughman
Copy link
Contributor Author

@ivanpauno Ok - I didn't do any assertions about the text part of the description - that's not meant to be a thing you use programmatically. I did check that the actions you give to the constructor come out the other side.

@pbaughman pbaughman requested a review from ivanpauno February 19, 2020 18:38
@pbaughman
Copy link
Contributor Author

@ivanpauno poke

@ivanpauno
Copy link
Member

ivanpauno commented Feb 20, 2020

CI:

  • Linux Build Status (unrelated failures)

@ivanpauno poke

I was OoO yesterday.

@ivanpauno ivanpauno added the in review Waiting for review (Kanban column) label Feb 20, 2020
@pbaughman
Copy link
Contributor Author

@ivanpauno This kind of looks like an issue with CI:

[ERROR] [launch]: Caught exception in launch (see debug for traceback): package 'demo_nodes_py' found at '/home/jenkins-agent/workspace/ci_linux/ws/install/demo_nodes_py', but libexec directory '/home/jenkins-agent/workspace/ci_linux/ws/install/demo_nodes_py/lib/demo_nodes_py' does not exist

Have you seen something like that before?

@pbaughman
Copy link
Contributor Author

I get the same errors when I build and test launch_ros master in osrf/ros2:nightly - I think something is broken upstream

[ERROR] [launch]: Caught exception in launch (see debug for traceback): package 'demo_nodes_py' found at '/opt/ros/foxy', but libexec directory '/opt/ros/foxy/lib/demo_nodes_py' does not exist

@pbaughman
Copy link
Contributor Author

Opened an issue here to try to get this fixed

@ivanpauno ivanpauno merged commit 96191f2 into ros2:master Feb 20, 2020
@ivanpauno
Copy link
Member

Thanks for the fix @pbaughman !
The test failures are unrelated, see ros2/build_farmer#266.

@pbaughman pbaughman deleted the issue_385_register_event_handler_describe_entities branch February 20, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in review Waiting for review (Kanban column)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants