Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to split arguments with shlex.split in ExecuteProcess #711

Open
wants to merge 12 commits into
base: rolling
Choose a base branch
from
Open

Add option to split arguments with shlex.split in ExecuteProcess #711

wants to merge 12 commits into from

Commits on Jan 22, 2024

  1. add split_arguments argument for ExecuteLocal 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    11beb25 View commit details
    Browse the repository at this point in the history

  2. add tests for split_arguments argument in ExecuteLocal 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4922f16 View commit details
    Browse the repository at this point in the history

  3. add missing test executable 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e45bed9 View commit details
    Browse the repository at this point in the history

  4. fixups 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    95abdc2 View commit details
    Browse the repository at this point in the history

  5. working on xml tests for split_arguments, not working yet 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    82069ed View commit details
    Browse the repository at this point in the history

  6. move logic out of async fn to avoid race, and fixups 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6e5c32d View commit details
    Browse the repository at this point in the history

  7. add yaml and xml tests for split_arguments 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    74f5f4c View commit details
    Browse the repository at this point in the history

  8. fixup yaml indent in test example 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1b6c759 View commit details
    Browse the repository at this point in the history

  9. conditionally set the shlex.split() mode for Windows 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    fae8e5c View commit details
    Browse the repository at this point in the history

  10. fixup typo 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1b7fb0d View commit details
    Browse the repository at this point in the history

  11. fix posix logic and add test 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    66d408b View commit details
    Browse the repository at this point in the history

  12. fixup tests 

    Signed-off-by: William Woodall <william@osrfoundation.org>
    @wjwwood
    wjwwood committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    03fed58 View commit details
    Browse the repository at this point in the history