Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composable node launch actions #9

Merged
merged 10 commits into from
Apr 16, 2019
Merged

Add composable node launch actions #9

merged 10 commits into from
Apr 16, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 22, 2019

This pull request adds ComposableNodeContainer and LoadComposableNodes actions to launch_ros.

Connected to #6. Copy of ros2/launch#197.

sloretz and others added 8 commits March 22, 2019 15:55
@sloretz @hidmic
Add stub files
d5bdbe4 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@hidmic
Add composable nodes description, container and load actions.
23b7784 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Change composable nodes load service naming.
4671ba8 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Flatten out parameter files when converting to messages.
1f94fd6 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Address peer review comments.
8495d8e 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Drop in_parallel loading for composable nodes.
4b6bda5 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Use launch.logging instead of plain logging.
bcfdd2f 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Fix lint issues.
e18d739 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from sloretz March 22, 2019 19:09
hidmic added 2 commits March 25, 2019 09:10
@hidmic
Address peer review comments.
3310d0b 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Improve launch_ros.actions.LoadComposableNodes logging.
40900d7 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Mar 25, 2019

Tested component loading using @mjcarroll draft PR ros2/rclcpp#665 and these launch actions are working as expected.

@wjwwood wjwwood mentioned this pull request Mar 27, 2019
Closed
@sloretz sloretz mentioned this pull request Apr 5, 2019
Closed
4 tasks
@hidmic
Copy link
Contributor Author

hidmic commented Apr 16, 2019

@sloretz @mjcarroll is there anything else we want to get in before merging this?

@mjcarroll
Copy link
Member

Nope, good to go from me

@hidmic
Copy link
Contributor Author

hidmic commented Apr 16, 2019 •
edited
Loading

CI (up to test_launch_ros):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Apr 16, 2019

Going in!

@hidmic hidmic merged commit c7f22b1 into master Apr 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/composable_node_actions branch April 16, 2019 19:02
@mjcarroll mjcarroll mentioned this pull request Apr 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz left review comments

@mjcarroll mjcarroll mjcarroll approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hidmic @mjcarroll @wjwwood @sloretz