-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail if we try to crosscompile while PYTHON_SOABI is not set. #12
Open
AlexisTM
wants to merge
5
commits into
ros2:rolling
Choose a base branch
from
AlexisTM:feature/fail_on_missing_SOABI_for_crosscompilation
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8010d88
Fail if we crosscompile while PYTHON_SOABI is not set.
AlexisTM 25839ff
Add the python_code variable, as it wouldn't be defined when called f…
AlexisTM bd2bbde
Add documentation to the function
AlexisTM b1862e2
Add documentation for the PYTHON_MODULE_EXTENSION and only set it whe…
AlexisTM ff3c4f4
Merge branch 'rolling' into feature/fail_on_missing_SOABI_for_crossco…
AlexisTM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Copyright 2022 Open Source Robotics Foundation, Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
function(CheckCrossCompilingSoabi) | ||
if(NOT DEFINED PYTHON_SOABI AND DEFINED CMAKE_SYSROOT) | ||
message(FATAL_ERROR "We detected you defined a sysroot thus crosscompiling.\n" | ||
"You have to define the PYTHON_SOABI variable in the toolchain file, which looks like cpython-39-x86_64-linux-gnu or cpython-39-aarch64-linux-gnu.\n" | ||
"" | ||
"To find the correct PYTHON_SOABI value, you can execute the following from the target:\n" | ||
"python3 -c \"${_python_code}\"\n" | ||
"" | ||
"Run it with qemu with: (expecting aarch64 as your \n" | ||
"qemu-aarch64-static -L ${CMAKE_SYSROOT} ${CMAKE_SYSROOT}/usr/bin/python3 -c \"${_python_code}\"\n" | ||
"" | ||
"The toolchain should look like:\n" | ||
"set(PYTHON_SOABI cpython-39-aarch64-linux-gnu)\n" | ||
) | ||
endif() | ||
endfunction() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fail early instead of on usage of this library (which is after compiling the rmw middleware).