Remove WIN specific compiler definition in configure_rcl

Signed-off-by: Sachin Suresh Bhat <bhatsach@amazon.com>
ros2 · Feb 26, 2019 · 67e851e · 67e851e
1 parent 1a4f48e
commit 67e851e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/rcl/CMakeLists.txt b/rcl/CMakeLists.txt
@@ -70,6 +70,9 @@ ament_target_dependencies(${PROJECT_NAME}
  "tinydir_vendor"
 )
 
+# Causes the visibility macros to use dllexport rather than dllimport,
+# which is appropriate when building the dll but not consuming it.
+target_compile_definitions(${PROJECT_NAME} PRIVATE "RCL_BUILDING_DLL")
 configure_rcl(${PROJECT_NAME} LANGUAGE "C")
 
 install(

diff --git a/rcl/cmake/configure_rcl.cmake b/rcl/cmake/configure_rcl.cmake
@@ -63,11 +63,4 @@ macro(configure_rcl library_target)
  else()
  message(FATAL_ERROR "configure_rcl() called with unsupported LANGUAGE: '${_ARG_LANGUAGE}'")
  endif()
-
- if(WIN32)
- # Causes the visibility macros to use dllexport rather than dllimport
- # which is appropriate when building the dll but not consuming it.
- target_compile_definitions(${library_target}
- PRIVATE "RCL_BUILDING_DLL")
- endif()
 endmacro()