fixed rcl_wait return error when timer cancelled (backport #1003) #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* add error msg in rcl wait Signed-off-by: kevin <kevin@floatic.io> * error not set reason changed Signed-off-by: kevin <kevin@floatic.io> * change error msg Signed-off-by: kevin <kevin@floatic.io> * change error msg Signed-off-by: kevin <kevin@floatic.io> * rcl wait bug when timer is cancelled Signed-off-by: kevin <kevin@floatic.io> * change step of check timer cancelled Signed-off-by: kevin <kevin@floatic.io> * fixed rcl_wait when timer cancelled Signed-off-by: kevin <kevin@floatic.io> * removed empty line Signed-off-by: ladianchad <qhrejddlvltm@gmail.com> Signed-off-by: kevin <kevin@floatic.io> Signed-off-by: ladianchad <qhrejddlvltm@gmail.com> Co-authored-by: kevin <kevin@floatic.io> (cherry picked from commit 4b125b1)
fujitatomoya
approved these changes
Sep 5, 2022
|
CI:
|
|
I don't think windows warning is related, merging. |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/preparing-for-humble-sync-2022-09-09/27240/2 |
|
Great! Can you tag/release it so it is included in the next sync ? https://discourse.ros.org/t/preparing-for-humble-sync-2022-09-09/27240/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1003 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com