Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make flaky timer tests work #1143

Closed
wants to merge 1 commit into from

Conversation

jmachowinski
Copy link
Contributor

This might fix the regression that was reportet by @clalancette.

Note, it does not fail on my local machine, and therefore I can not verify if it fixes the issue.

@clalancette
Copy link
Contributor

Note, it does not fail on my local machine, and therefore I can not verify if it fixes the issue.

Hm, that's surprising. It fails like 90% of the time locally for me.

@clalancette
Copy link
Contributor

Here's just Linux CI with this:

  • Linux Build Status

@clalancette
Copy link
Contributor

Actually, the build farm is quiet, so here are jobs on all platforms just in case this fixes it:

  • Linux-aarch64 Build Status
  • Windows Build Status

…ncel

Signed-off-by: Janosch Machowinski <j.machowinski@nospam.org>
@jmachowinski
Copy link
Contributor Author

hm, still fails.

@jmachowinski
Copy link
Contributor Author

Hm, that's surprising. It fails like 90% of the time locally for me.
My failure, I was still on a rclcpp version before the merge of ros2/rclcpp#2142

This PR is obsolete and supersedes by #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants