rcl_action - user friendly error messages for invalid transitions #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
skucheria
force-pushed
the
kucheria/rcl_action
branch
from
bcabfa5
to
d8517c4
Compare
jacobperron
reviewed
May 21, 2019
There was a problem hiding this comment.
I think it would be better if the descriptions were tied closer to their enum types.
We can declare them in types.h (close to the enums) and define them in types.c.
A comment can also be added to the enum with a reminder that the description variables should be changed if the enum values change.
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
skucheria
force-pushed
the
kucheria/rcl_action
branch
from
4375391
to
cf88f63
Compare
jacobperron
approved these changes
May 21, 2019
rcl_action/src/rcl_action/types.c
Outdated
| @@ -132,6 +132,13 @@ rcl_action_cancel_response_fini(rcl_action_cancel_response_t * cancel_response) | |||
| return RCL_RET_OK; | |||
| } | |||
|
|
|||
| /// Values should be changed if enum values chang | |||
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
skucheria
force-pushed
the
kucheria/rcl_action
branch
from
b8128df
to
2fdf2bf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jacobperron
Fixes #417