Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning when remapping to an invalid node name #454

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Log warning when remapping to an invalid node name #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rcl/src/rcl/arguments.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,9 @@ _rcl_parse_remap_nodename_replacement(
// new_node_name
ret = rcl_lexer_lookahead2_expect(lex_lookahead, RCL_LEXEME_TOKEN, &node_name, &length);
if (RCL_RET_WRONG_LEXEME == ret) {
node_name = rcl_lexer_lookahead2_get_text(lex_lookahead);
RCUTILS_LOG_WARN_NAMED(
ROS_PACKAGE_NAME, "Node name not remapped to invalid name: '%s'", node_name);
return RCL_RET_INVALID_REMAP_RULE;
}
if (RCL_RET_OK != ret) {
Expand Down