Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML Parser] Support parameter value parsing #471

Merged
merged 3 commits into from
Jul 12, 2019
Merged

[YAML Parser] Support parameter value parsing #471

merged 3 commits into from
Jul 12, 2019

Commits on Jul 12, 2019

  1. Support parameter YAML string value parsing. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    2323b69 View commit details
    Browse the repository at this point in the history

  2. Address peer review comments. 

    - Improve test coverage using new getter API.
- Unify function return style and improve readability.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    1d2555e View commit details
    Browse the repository at this point in the history

  3. Clean up allocations in rcl_yaml_param_parser package tests. 

    Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
    @hidmic
    hidmic committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    8716384 View commit details
    Browse the repository at this point in the history