Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable incremental parameter yaml file parsing. #507

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Enable incremental parameter yaml file parsing. #507

merged 1 commit into from
Sep 24, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 23, 2019

This pull request allows YAML parameter files parsing to update an already populated rcl_params_t structure, enabling incremental parsing.

@hidmic
Enable incremental parameter yaml file parsing.
8e56c51 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Sep 23, 2019 •
edited
Loading

Running CI up to rcl, testing rcl_yaml_param_parser and rcl.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic mentioned this pull request Sep 23, 2019
Merged
jacobperron
jacobperron approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic
Copy link
Contributor Author

hidmic commented Sep 24, 2019

Going in.

@hidmic hidmic merged commit 78f8652 into master Sep 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/incremental-yaml-file-parsing branch September 24, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @jacobperron @ivanpauno