Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foxy backport] Fixed doxygen warnings (#677) #696

Merged
merged 1 commit into from
Jun 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rcl/include/rcl/arguments.h
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ rcl_arguments_get_count_unparsed_ros(
*
* \param[in] args An arguments structure that has been parsed.
* \param[in] allocator A valid allocator.
* \param[out] output_unparsed_indices An allocated array of indices into the original argv array.
* \param[out] output_unparsed_ros_indices An allocated array of indices into the original argv array.
* This array must be deallocated by the caller using the given allocator.
* If there are no unparsed ROS specific arguments then the output will be set to NULL.
* \return `RCL_RET_OK` if everything goes correctly, or
Expand Down
2 changes: 1 addition & 1 deletion rcl/include/rcl/event.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ rcl_subscription_event_init(
/**
* Take an event from the event handle.
*
* \param[in] event_handle event object to take from
* \param[in] event event object to take from
* \param[in, out] event_info event info object to write taken data into
* \return `RCL_RET_OK` if successful, or
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or
Expand Down
4 changes: 2 additions & 2 deletions rcl/include/rcl/graph.h
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ rcl_names_and_types_fini(rcl_names_and_types_t * names_and_types);
* \param[in] node the handle to the node being used to query the ROS graph
* \param[in] allocator used to control allocation and deallocation of names
* \param[out] node_names struct storing discovered node names
* \param[out] node_namesspaces struct storing discovered node namespaces
* \param[out] node_namespaces struct storing discovered node namespaces
* \return `RCL_RET_OK` if the query was successful, or
* \return `RCL_RET_BAD_ALLOC` if an error occurred while allocating memory, or
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or
Expand Down Expand Up @@ -459,7 +459,7 @@ rcl_get_node_names(
* \param[in] node the handle to the node being used to query the ROS graph
* \param[in] allocator used to control allocation and deallocation of names
* \param[out] node_names struct storing discovered node names
* \param[out] node_namesspaces struct storing discovered node namespaces
* \param[out] node_namespaces struct storing discovered node namespaces
* \param[out] enclaves struct storing discovered node enclaves
* \return `RCL_RET_OK` if the query was successful, or
* \return `RCL_RET_BAD_ALLOC` if an error occurred while allocating memory, or
Expand Down
3 changes: 2 additions & 1 deletion rcl/include/rcl/logging_rosout.h
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ rcl_logging_rosout_fini_publisher_for_node(
* \param[in] severity The severity level
* \param[in] name The name of the logger, must be null terminated c string
* \param[in] timestamp The timestamp for when the log message was made
* \param[in] log_str The string to be logged
* \param[in] format The list of arguments to insert into the formatted log message
* \param[in] args argument for the string format
*/
RCL_PUBLIC
void rcl_logging_rosout_output_handler(
Expand Down
2 changes: 1 addition & 1 deletion rcl/include/rcl/node_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ rcl_node_options_copy(
* Uses Atomics | Yes
* Lock-Free | Yes
*
* \param[inout] node_options object to be finalized
* \param[inout] options object to be finalized
* \return `RCL_RET_OK` if setup is successful, or
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or
* \return `RCL_RET_ERROR` if an unspecified error occurs.
Expand Down
2 changes: 1 addition & 1 deletion rcl/include/rcl/remap.h
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ rcl_remap_node_namespace(
* Uses Atomics | No
* Lock-Free | Yes
*
* \param[in] args The structure to be deallocated.
* \param[in] remap The structure to be deallocated.
* \return `RCL_RET_OK` if the memory was successfully freed, or
* \return `RCL_RET_INVALID_ARGUMENT` if any function arguments are invalid, or
* \return `RCL_RET_ERROR` if an unspecified error occurs.
Expand Down
3 changes: 3 additions & 0 deletions rcl/include/rcl/validate_topic_name.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ rcl_validate_topic_name(
/// Validate a given topic name.
/**
* This is an overload with an extra parameter for the length of topic_name.
* \param[in] topic_name the topic name to be validated, must be null terminated
* \param[in] topic_name_length The number of characters in topic_name.
* \param[out] validation_result the reason for validation failure, if any
* \param[out] invalid_index index of violation if the input topic is invalid
*
* \sa rcl_validate_topic_name(const char *, int *, size_t *)
*/
Expand Down
1 change: 1 addition & 0 deletions rcl/src/rcl/arguments.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ _rcl_parse_external_log_config_file(
* The syntax of the file name is not validated.
* \param[in] arg the argument to parse
* \param[in] allocator an allocator to use
* \param[in] params points to the populated parameter struct
* \param[in,out] param_file string that could be a parameter file name
* \return RCL_RET_OK if the rule was parsed correctly, or
* \return RCL_RET_BAD_ALLOC if an allocation failed, or
Expand Down
4 changes: 2 additions & 2 deletions rcl_action/include/rcl_action/action_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ rcl_action_send_result_request(
*
* \param[in] action_client handle to the client that will take the result response
* \param[out] response_header pointer to the result response header
* \param[out] ros_result_response preallocated, zero-initialized, struct where the ROS
* \param[out] ros_result preallocated, zero-initialized, struct where the ROS
* result message is copied.
* \return `RCL_RET_OK` if the response was taken successfully, or
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or
Expand Down Expand Up @@ -639,7 +639,7 @@ rcl_action_send_cancel_request(
* Lock-Free | Yes
*
* \param[in] action_client handle to the client that will take the cancel response
* \param[out] request_header pointer to the cancel response header
* \param[out] response_header pointer to the cancel response header
* \param[out] ros_cancel_response a zero-initialized ROS cancel response message where
* the cancel response is copied.
* \return `RCL_RET_OK` if the response was taken successfully, or
Expand Down
2 changes: 1 addition & 1 deletion rcl_action/include/rcl_action/action_server.h
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ rcl_action_take_cancel_request(
*
* \param[in] action_server handle to the action server that will process the cancel request
* \param[in] cancel_request a C-typed ROS cancel request to process
* \param[out] cancel_reponse a zero-initialized cancel response struct
* \param[out] cancel_response a zero-initialized cancel response struct
* where the goal info of goals which should be cancelled are copied
* \return `RCL_RET_OK` if the response was sent successfully, or
* \return `RCL_RET_INVALID_ARGUMENT` if any arguments are invalid, or
Expand Down
4 changes: 3 additions & 1 deletion rcl_action/include/rcl_action/wait.h
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,11 @@ rcl_action_server_wait_set_get_num_entities(
* Uses Atomics | No
* Lock-Free | Yes
*
* \param[in] wait_set struct where action server services are to be stored
* \param[in] action_client an action client to query
* \param[out] is_feedback_ready `true` if there is a feedback message ready to take,
* `false` otherwise
* \param[out] is_status_message `true` if there is a status message ready to take,
* \param[out] is_status_ready `true` if there is a status message ready to take,
* `false` otherwise
* \param[out] is_goal_response_ready `true` if there is a goal response message ready
* to take, `false` otherwise
Expand Down Expand Up @@ -251,6 +252,7 @@ rcl_action_client_wait_set_get_entities_ready(
* Uses Atomics | No
* Lock-Free | Yes
*
* \param[in] wait_set struct where action server services are to be stored
* \param[in] action_server an action server to query
* \param[out] is_goal_request_ready `true` if there is a goal request message ready
* to take, `false` otherwise
Expand Down