Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove domain_id and localhost_only from node_options #708

Merged
merged 6 commits into from
Jul 8, 2020
Merged

Remove domain_id and localhost_only from node_options #708

merged 6 commits into from
Jul 8, 2020

Commits on Jul 6, 2020

  1. Delete domain_id and localhost_only from node API 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    8ff2c77 View commit details
    Browse the repository at this point in the history

  2. Adapt tests 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    cfbfad7 View commit details
    Browse the repository at this point in the history

  3. Delete usage of domain_id in node_options 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    d309e2a View commit details
    Browse the repository at this point in the history

  4. Add const qualifiers of functions 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    6669c06 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Add missing const qualifier 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
    @ivanpauno
    ivanpauno committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    c0858f6 View commit details
    Browse the repository at this point in the history

  2. Add error message if assertion fails 

    Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com>
    @ivanpauno @hidmic
    ivanpauno and hidmic authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    4cf9b22 View commit details
    Browse the repository at this point in the history