Set transition_map->states/transition size to 0 on fini #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/rcl_lifecycle-states-size
branch
from
5ee4d06
to
bf21179
Compare
|
Rebased onto master
|
Karsten1987
approved these changes
Aug 12, 2020
|
Thanks for the reviews! |
brawner
added a commit
that referenced
this pull request
Oct 5, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
added a commit
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered during fault injection tests. But states_size and transititions_size need to be set to 0 on finalization because if finalization is ever called again, the for loop is entered without checking if states is null.
Signed-off-by: Stephen Brawner brawner@gmail.com