Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_publisher_wait_all_ack depends on rcpputils #968

Merged
merged 2 commits into from
Mar 14, 2022
Merged

test_publisher_wait_all_ack depends on rcpputils #968

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22eb7a9
test_publisher_wait_all_ack depends on rcpputils
sloretz Mar 14, 2022
e4d8978
Alphabetize and add rcutils and rosidl_runtime_c deps
sloretz Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rcl/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ function(test_target_function)
APPEND_LIBRARY_DIRS ${extra_lib_dirs}
INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/../src/rcl/
LIBRARIES ${PROJECT_NAME} mimick wait_for_entity_helpers
AMENT_DEPENDENCIES ${rmw_implementation} "osrf_testing_tools_cpp" "test_msgs"
AMENT_DEPENDENCIES ${rmw_implementation} "osrf_testing_tools_cpp" "test_msgs" "rcpputils"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, it also depends on rosidl_runtime_c and rcutils as well.

It would also be nice to keep this list in alphabetical order. But neither of these are blocking, so I'll approve anyway and let you decide whether to fix them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetized and added those two deps as well in e4d8978

)

rcl_add_custom_gtest(test_service${target_suffix}
Expand Down