Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming everything with an 'rcl_' prefix instead of an 'rc_' prefix … #2

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Renaming everything with an 'rcl_' prefix instead of an 'rc_' prefix … #2

merged 1 commit into from
Dec 6, 2018

Conversation

nburek
Copy link
Contributor

@nburek nburek commented Dec 6, 2018

Renaming everything with an 'rcl_' prefix instead of an 'rc_' prefix to match the change in 'rcl'

Connects to ros2/rcl#327

@nburek nburek requested a review from wjwwood December 6, 2018 20:03
@wjwwood
Copy link
Member

wjwwood commented Dec 6, 2018

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@wjwwood
Copy link
Member

wjwwood commented Dec 6, 2018

I can rename the repository for you (and propose a change to the ros2.repos file as well) after this. Thanks!

@wjwwood
Copy link
Member

wjwwood commented Dec 6, 2018

Oh these are COLCON_IGNORE'd. So no CI should be needed.

@wjwwood
Copy link
Member

wjwwood commented Dec 6, 2018

Actually wrong, just the log4cxx is ignored, here's Linux CI for the noop one:

Build Status

@wjwwood wjwwood merged commit 12d0337 into ros2:master Dec 6, 2018
@wjwwood wjwwood mentioned this pull request Dec 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nburek @wjwwood