add some doxygen and fix uncrustify

Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>

rclcpp/include/rclcpp/executors/executor_notify_waitable.hpp

@@ -88,22 +88,37 @@ class ExecutorNotifyWaitable : public rclcpp::Waitable
  std::shared_ptr<void>
  take_data() override;
 
- /// Add a guard condition to be waited on.
+ /// Take the data from an entity ID so that it can be consumed with `execute`.
  /**
- * \param[in] guard_condition The guard condition to add.
+ * \param[in] id ID of the entity to take data from.
+ * \return If available, data to be used, otherwise nullptr
+ * \sa rclcpp::Waitable::take_data_by_entity_id
  */
  RCLCPP_PUBLIC
  std::shared_ptr<void>
  take_data_by_entity_id(size_t id) override;
 
+ /// Set a callback to be called whenever the waitable becomes ready.
+ /**
+ * \param[in] callback callback to set
+ * \sa rclcpp::Waitable::set_on_ready_callback
+ */
  RCLCPP_PUBLIC
  void
  set_on_ready_callback(std::function<void(size_t, int)> callback) override;
 
+ /// Add a guard condition to be waited on.
+ /**
+ * \param[in] guard_condition The guard condition to add.
+ */
  RCLCPP_PUBLIC
  void
  add_guard_condition(rclcpp::GuardCondition::WeakPtr guard_condition);
 
+ /// Unset any callback registered via set_on_ready_callback.
+ /**
+ * \sa rclcpp::Waitable::clear_on_ready_callback
+ */
  RCLCPP_PUBLIC
  void
  clear_on_ready_callback() override;

rclcpp/include/rclcpp/experimental/timers_manager.hpp

@@ -78,8 +78,8 @@ class TimersManager
  * If it's callable, it will be invoked instead of the timer callback.
  * If it's not callable, then the TimersManager will
  * directly execute timers when they are ready.
- * All the methods that execute a given timer (e.g. `execute_head_timer` 
- * or `execute_ready_timer`) without the TimersManager being `running`, i.e. 
+ * All the methods that execute a given timer (e.g. `execute_head_timer`
+ * or `execute_ready_timer`) without the TimersManager being `running`, i.e.
  * without actually explicitly waiting for the timer to become ready, will ignore this
  * callback.
  */