-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only one timer + MultiThreadedExecutor will block executor #877
Comments
On Dashing version, fixing suggestion
|
Could you provide an example of the problem? |
This interrupt in
exist to avoid a thread, in the case the executor is multithreaded and the threads are not mutually exclusive, waiting indefinitely in
If the interrupt guard condition did not exist, your solution will still not work because the thread will be waiting in |
@peterpena I don't see the connection between your comment and @liqinghua bug report. PS: There was a thread safety problem that made |
Otherwise, the callback could attempt to take a reference to a guard condition that has already been deleted. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
In particular, mark consumer_buffer() as ACQUIRE and release_consumer_buffer() as RELEASE. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Bug report
Required Info:
Issue
On Dashing, will block executor, and cannot be recover
On Master, will block until next_exec_timeout_
The text was updated successfully, but these errors were encountered: