add version of create_subscription which just takes queue size and not a qos profile #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
CI is good, up for review. |
wjwwood
added
in review
|
Also up for review is this one: ros2/system_tests#56 |
|
+1 In the future I think we should have a one set of method (which is as small as possible) providing the core functionality. And beside that a separate set of methods which are only syntactic sugar and reusing the core functionality internally but expose a different interface. |
wjwwood
added a commit
that referenced
this pull request
Oct 14, 2015
add version of create_subscription which just takes queue size and not a qos profile
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* ros2GH-112 Open storage for reading handing in rmw_identifier * ros2GH-113 Cleanup: better naming * ros2GH-113 Introduce interface for StorageFactory to allow mocks in tests * ros2GH-113 Add test for SequentialReader for using converters - Added mocks for storage and converters (and factories) * ros2GH-113 Implement skeleton convert function - Use convert only if necessary (different input and output formats), converters are only loaded if really necessary. - Allocate_ros2_message is public to enable extensive tests for this function. - Helper function to get any typesupport by name - Helper function for empty ros2_message * ros2GH-113 Implement allocate_ros2_message - Treats most messages already. - Some combinations of nested messages with arrays are still missing - Cleanup of DynamicArrayNested messages is failing - Main difficulty is the cleanup of the allocated ros2_message which needs to be done manually - The test_ros2_message is intended to be run with valgrind and there should be no leaks or problems with free! * ros2GH-113 Fix DynamicArrayNested deallocation Swapping with empty container seems more stable than deleting the data pointer of the container. * ros2GH-113 Add test for BoundedArrayNested deallocation * ros2GH-113 Refactoring of deallocation code * ros2GH-113 Fix string initialization in all types * ros2GH-113 Fix vector<bool> initialization * ros2GH-113 Add test for deallocation of topic name + Refactoring * ros2GH-113 Minor refactoring of converter * ros2GH-113 Make sure to throw an error if converters do not exist * ros2GH-113 Delete superfluous imports * ros2GH-113 Small fix for deleting vectors * ros2GH-113 Fix build after rebase * ros2GH-30 Minor refactoring - The TODO comments have been removed because they're no longer relevant: they have been discussed in the PR review * ros2GH-30 Give an allocator as parameter to allocate_ros2_message() * ros2GH-111 Add missing test dependencies for CDR converter test * ros2GH-128 Extend message allocation test to also cover big strings - Big strings are not treated with small string optimization and need to be checked, too. * ros2GH-128 Add tests for nested arrays * ros2GH-128 always initialize vectors with a placement new * pass by ref * use new getter functions * consistent function naming * uncrustify * ros2GH-30 Fix windows build * use visibility macros on all functions
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Add support for parsing middle module name from type Allows support for message types generated from both msg and idl files. Signed-off-by: David Hodo <david.hodo@is4s.com> * test fixups and default behavior Signed-off-by: Karsten Knese <karsten@openrobotics.org> * deprecate legacy type extraction and add new Signed-off-by: David Hodo <david.hodo@is4s.com> * use pragma to avoid deprecation in test Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/design#56.