add automatically_add_executor_with_node option

[BriceRenaudeau]

This PR tries to implement #1589

It adds the automatically_add_executor_with_node option when creating a callback_group for a LifecycleNode.

[fujitatomoya]

@BriceRenaudeau

thanks for opening PR 👍

could you also take care of DCO failure https://github.com/ros2/rclcpp/pull/1594/checks?check_run_id=2183190459?

[wjwwood]

Also, since this API is not covered by https://github.com/ros2/rclcpp/blob/master/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp, can you maybe add some code here to just exercise the new API?

rclcpp/rclcpp_lifecycle/test/test_lifecycle_node.cpp

Lines 663 to 675 in 0088e35

	TEST_F(TestDefaultStateMachine, test_callback_groups) {
	auto test_node = std::make_shared<EmptyLifecycleNode>("testnode");
	auto groups = test_node->get_callback_groups();
	EXPECT_EQ(groups.size(), 1u);
	auto group = test_node->create_callback_group(
	rclcpp::CallbackGroupType::MutuallyExclusive);
	EXPECT_NE(nullptr, group);
	groups = test_node->get_callback_groups();
	EXPECT_EQ(groups.size(), 2u);
	EXPECT_EQ(groups[1].lock().get(), group.get());
	}

[wjwwood]

@ros-pull-request-builder retest this please

[wjwwood]

CI:

• Linux
• Linux-aarch64
• macOS
• Windows