deprecated callback_group from publisher option #1853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI with
|
iuhilnehc-ynos
force-pushed
the
topic-publisher-not-hold-callback-group
branch
3 times, most recently
from
e89dd70 to
4cd8527
Compare
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
|
Rerun CI:
|
|
@iuhilnehc-ynos thanks for the follow-up, i will also take a look at this. |
|
Should we wait for #1833 to be merged first? |
|
@alsora i think so, since this is follow-up. |
|
@iuhilnehc-ynos this should be closed aligned with #1833? if that so, please go ahead to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR for #1833.
Signed-off-by: Chen Lihui lihui.chen@sony.com