Use spin() in component_manager_isolated.hpp #1881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
spin_until_future_complete
withspin
incomponent_manager_isolated.hpp
.spin_until_future_complete()
is more inefficient as it needs to check the state of the future and the timeout after every work iteration.This PR addresses the race-condition issues mentioned in #1781 by using the recently added
is_spinning()
APITests on the navigation stack show 10% less CPU usage when using
spin()
rather thanspin_until_future_complete()
FYI @SteveMacenski @gezp @ivanpauno