Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use universal reference to support rvalue. #1883

Merged
merged 2 commits into from
Feb 10, 2022
Merged

use universal reference to support rvalue. #1883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2555720
use universal reference to support rvalue.
fujitatomoya Feb 2, 2022
e3282bb
add test cases.
fujitatomoya Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclcpp/include/rclcpp/create_publisher.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ template<
typename NodeT>
std::shared_ptr<PublisherT>
create_publisher(
NodeT & node,
NodeT && node,
fujitatomoya marked this conversation as resolved.
Show resolved Hide resolved
const std::string & topic_name,
const rclcpp::QoS & qos,
const rclcpp::PublisherOptionsWithAllocator<AllocatorT> & options = (
Expand Down
11 changes: 11 additions & 0 deletions rclcpp/test/rclcpp/test_publisher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,17 @@ TEST_F(TestPublisher, various_creation_signatures) {
rclcpp::create_publisher<Empty>(node, "topic", 42, options);
(void)publisher;
}
{
auto publisher = rclcpp::create_publisher<Empty>(
node->get_node_topics_interface(), "topic", 42, rclcpp::PublisherOptions());
(void)publisher;
}
{
auto node_topics_interface = node->get_node_topics_interface();
auto publisher = rclcpp::create_publisher<Empty>(
node_topics_interface, "topic", 42, rclcpp::PublisherOptions());
(void)publisher;
}
{
auto node_parameters = node->get_node_parameters_interface();
auto node_topics = node->get_node_topics_interface();
Expand Down