-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory leak #1994
Merged
fujitatomoya
merged 1 commit into
ros2:rolling
from
iuhilnehc-ynos:toipc-memory-leak-param-client
Aug 18, 2022
Merged
fix memory leak #1994
fujitatomoya
merged 1 commit into
ros2:rolling
from
iuhilnehc-ynos:toipc-memory-leak-param-client
Aug 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for fixing the leak!
clalancette
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix. Looks good with green CI.
fujitatomoya
approved these changes
Aug 18, 2022
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 29, 2023
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
May 3, 2023
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #1993
Signed-off-by: Chen Lihui lihui.chen@sony.com