Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url to API doc in readme #2058

Closed
wants to merge 0 commits into from
Closed

Fix url to API doc in readme #2058

wants to merge 0 commits into from

Conversation

jrutgeer
Copy link
Contributor

@jrutgeer jrutgeer commented Dec 6, 2022

Changed README to point to the API doc via the rclcpp package info page at the ROS Index.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrutgeer thanks for the contribution, this PR surely fixes one link, which is good. but i can see there are many places use docs.ros2.org, so those probably need to be changed as well. besides we are having discussion on ros2/ros2#1354.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll wait a bit longer before merging to get other opinions.

@clalancette
Copy link
Contributor

We've had no further reviews, so I'm happy to merge it as-is.

@jrutgeer I just realized that the DCO bot is unhappy because the commit does not have the Signed-off-by: line. Can you please rebase, add that, and then force-push it? Once that is done we can merge.

@jrutgeer jrutgeer closed this Dec 15, 2022
@jrutgeer
Copy link
Contributor Author

@clalancette I tried to do that, but I think I failed.
Also when I press compare above it seems that 18 files were changed??
I don´t know how come I could have had write access to this repository and not only my local fork?

@clalancette
Copy link
Contributor

I don´t know how come I could have had write access to this repository and not only my local fork?

You only have access to your local fork. Because you did a merge, you brought in changes that happened since your fork.

In this case, the easiest thing to do is to just make a brand-new commit with a Signed-off-by line, and then open a new PR.

@jrutgeer jrutgeer deleted the fix-API-url branch December 23, 2022 08:50
@jrutgeer jrutgeer mentioned this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants