revert call shutdown in LifecycleNode destructor #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d8d83a0. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
commented
Jun 10, 2024
| // release sub-interfaces in an order that allows them to consult with node_base during tear-down | ||
| node_waitables_.reset(); | ||
| node_type_descriptions_.reset(); |
There was a problem hiding this comment.
this is actually bug fix, i will re-submit this after revert as follow-up.
| @@ -191,7 +162,6 @@ LifecycleNode::~LifecycleNode() | |||
| node_timers_.reset(); | |||
| node_logging_.reset(); | |||
| node_graph_.reset(); | |||
| node_base_.reset(); | |||
There was a problem hiding this comment.
this is actually bug fix, i will re-submit this after revert as follow-up.
|
CI (
|
wjwwood
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert #2528 and #2545
backports are not straight-forward because of the conflicts, so end up having backport PRs for each distro.