Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated APIs from component_manager.hpp #2585

Merged
merged 1 commit into from
Jul 16, 2024
Merged

remove deprecated APIs from component_manager.hpp #2585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions rclcpp_components/include/rclcpp_components/component_manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,20 +185,6 @@ class ComponentManager : public rclcpp::Node
const std::shared_ptr<LoadNode::Request> request,
std::shared_ptr<LoadNode::Response> response);

/**
* \deprecated Use on_load_node() instead
*/
[[deprecated("Use on_load_node() instead")]]
RCLCPP_COMPONENTS_PUBLIC
virtual void
OnLoadNode(
const std::shared_ptr<rmw_request_id_t> request_header,
const std::shared_ptr<LoadNode::Request> request,
std::shared_ptr<LoadNode::Response> response)
{
on_load_node(request_header, request, response);
}

/// Service callback to unload a node in the component
/**
* \param request_header unused
Expand All @@ -213,20 +199,6 @@ class ComponentManager : public rclcpp::Node
const std::shared_ptr<UnloadNode::Request> request,
std::shared_ptr<UnloadNode::Response> response);

/**
* \deprecated Use on_unload_node() instead
*/
[[deprecated("Use on_unload_node() instead")]]
RCLCPP_COMPONENTS_PUBLIC
virtual void
OnUnloadNode(
const std::shared_ptr<rmw_request_id_t> request_header,
const std::shared_ptr<UnloadNode::Request> request,
std::shared_ptr<UnloadNode::Response> response)
{
on_unload_node(request_header, request, response);
}

/// Service callback to get the list of nodes in the component
/**
* Return a two list: one with the unique identifiers and other with full name of the nodes.
Expand All @@ -242,20 +214,6 @@ class ComponentManager : public rclcpp::Node
const std::shared_ptr<ListNodes::Request> request,
std::shared_ptr<ListNodes::Response> response);

/**
* \deprecated Use on_list_nodes() instead
*/
[[deprecated("Use on_list_nodes() instead")]]
RCLCPP_COMPONENTS_PUBLIC
virtual void
OnListNodes(
const std::shared_ptr<rmw_request_id_t> request_header,
const std::shared_ptr<ListNodes::Request> request,
std::shared_ptr<ListNodes::Response> response)
{
on_list_nodes(request_header, request, response);
}

protected:
std::weak_ptr<rclcpp::Executor> executor_;

Expand Down