print warning if event callback is not supported instead of passing e… #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xception. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
fujitatomoya
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
fujitatomoya
commented
Oct 9, 2024
Comment on lines
-163
to
+178
| RCLCPP_DEBUG( | ||
| RCLCPP_WARN( | ||
| rclcpp::get_logger("rclcpp"), | ||
| "Failed to add event handler for incompatible qos; wrong callback type"); | ||
| "Failed to add event handler for incompatible qos; not supported"); |
There was a problem hiding this comment.
I think warning is more appropriate here, this is more visible for user that the callback type is not supported with this rmw implementation. besides, message is wrong, that is just not supported.
Yadunund
approved these changes
Oct 9, 2024
|
Pulls: #2648
|
ahcorde
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xception.
replaces #2644
rmw_zenoh) might not support those publisher / subscription event callbacks. I think that is okay to returnUNSUPPORTEDfrom RMW implementation. (RMW implementation does not have to support all RMW interfaces.)rmw_zenohcan generate the exception butrmw_fastrtps, this situation should be avoided.)