initial import for lifecycle subscriber #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karsten1987
commented
Dec 15, 2016
| @@ -77,8 +77,7 @@ create_subscription_factory( | |||
| AnySubscriptionCallback<MessageT, Alloc> any_subscription_callback(allocator); | |||
| any_subscription_callback.set(std::forward<CallbackT>(callback)); | |||
|
|
|||
| auto message_alloc = | |||
| std::make_shared<typename subscription::Subscription<MessageT, Alloc>::MessageAlloc>(); | |||
| auto message_alloc = std::make_shared<typename subscription::Subscription<MessageT, Alloc>::MessageAlloc>(); | |||
There was a problem hiding this comment.
Not sure if we have to create a SubscriptionT allocator here
44 tasks
|
@Karsten1987 what is the status of this ? Should this stay stale or be closed ? |
|
The status is as mentioned in the above comment. This commit compiles, but segfaults. I'll have to debug this in purpose with @wjwwood. |
|
Closing because this has stayed stale too long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wjwwood initial import for lifecycle_subscriber and the respective fixes for the subscription factory.
This is work in progress.