Allow logger to be passed into macros as a reference #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the type when captured by reference in a lambda; windows can't resolve it without.
wjwwood
approved these changes
Dec 5, 2017
rclcpp/resource/logging.hpp.em
Outdated
| @@ -85,7 +85,7 @@ def is_supported_feature_combination(feature_combination): | |||
| * \param ... The format string, followed by the variable arguments for the format string | |||
| */ | |||
| #define RCLCPP_@(severity)@(suffix)(logger, @(''.join([p + ', ' for p in get_macro_parameters(feature_combination).keys()]))...) \ | |||
| static_assert(::std::is_same<decltype(logger), ::rclcpp::Logger>::value, "First argument to logging macros must be an rclcpp::Logger"); \ | |||
| static_assert(::std::is_same<std::remove_reference<decltype(logger)>::type, ::rclcpp::Logger>::value, "First argument to logging macros must be an rclcpp::Logger"); \ | |||
There was a problem hiding this comment.
nitpick: Line is looking very long :)
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Abby Xu <abbyxu@amazon.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when captured by a lambda as in https://github.com/ros2/demos/pull/205/files#diff-f3c8fd029db528b5408e0a785999636eR135 it does not pass the
rclcpp::Loggertype check because it isrclcpp::Logger &CI windows including the logger usage in ros2/demos#205:
(
image_toolstesting passed)