Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor init to allow for non-global init #587

Merged
merged 15 commits into from
Nov 30, 2018
Merged

refactor init to allow for non-global init #587

merged 15 commits into from
Nov 30, 2018

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Nov 19, 2018

Connects to ros2/rmw#154

@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Nov 19, 2018
@wjwwood wjwwood self-assigned this Nov 19, 2018
@jacobperron jacobperron self-requested a review November 26, 2018 18:43
Signed-off-by: William Woodall <william@osrfoundation.org>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpicks along with a few questions and bugs spotted (I think).

rclcpp/include/rclcpp/utilities.hpp Outdated Show resolved Hide resolved
rclcpp/include/rclcpp/utilities.hpp Outdated Show resolved Hide resolved
rclcpp/include/rclcpp/utilities.hpp Outdated Show resolved Hide resolved
rclcpp/include/rclcpp/utilities.hpp Show resolved Hide resolved
rclcpp/include/rclcpp/utilities.hpp Outdated Show resolved Hide resolved
rclcpp/src/rclcpp/utilities.cpp Outdated Show resolved Hide resolved
rclcpp/src/rclcpp/utilities.cpp Outdated Show resolved Hide resolved
rclcpp/src/rclcpp/utilities.cpp Outdated Show resolved Hide resolved
rclcpp/src/rclcpp/utilities.cpp Outdated Show resolved Hide resolved
rclcpp/src/rclcpp/utilities.cpp Outdated Show resolved Hide resolved
jacobperron and others added 11 commits November 27, 2018 00:08
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Co-Authored-By: wjwwood <william+github@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, LGTM

rclcpp/src/rclcpp/context.cpp Show resolved Hide resolved
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood dismissed jacobperron’s stale review November 30, 2018 00:00

shane took over reviewing

@wjwwood wjwwood merged commit 3af8d2c into master Nov 30, 2018
@wjwwood wjwwood deleted the refactor_init branch November 30, 2018 05:33
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Nov 30, 2018
cho3 pushed a commit to cho3/rclcpp that referenced this pull request Jun 3, 2019
* refactor init to allow for non-global init

Signed-off-by: William Woodall <william@osrfoundation.org>

* Update rclcpp/include/rclcpp/utilities.hpp

Co-Authored-By: wjwwood <william+github@osrfoundation.org>

* Update rclcpp/include/rclcpp/utilities.hpp

Co-Authored-By: wjwwood <william+github@osrfoundation.org>

* Update rclcpp/include/rclcpp/utilities.hpp

Co-Authored-By: wjwwood <william+github@osrfoundation.org>

* Update rclcpp/src/rclcpp/utilities.cpp

Co-Authored-By: wjwwood <william+github@osrfoundation.org>

* refactor state into context objects and fix signal handling

Signed-off-by: William Woodall <william@osrfoundation.org>

* avoid nullptr access in error messages

Signed-off-by: William Woodall <william@osrfoundation.org>

* avoid exception in publish after shutdown was called

Signed-off-by: William Woodall <william@osrfoundation.org>

* fix missing and unused headers

Signed-off-by: William Woodall <william@osrfoundation.org>

* cpplint

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixes found during testing

Signed-off-by: William Woodall <william@osrfoundation.org>

* address bug found in review comment

Signed-off-by: William Woodall <william@osrfoundation.org>

* fixes and warnings fixed during testing

Signed-off-by: William Woodall <william@osrfoundation.org>

* addressing review comments

Signed-off-by: William Woodall <william@osrfoundation.org>

* ensure new ExecutorArgs are used everywhere
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants