fix error handling in node constructor #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
force-pushed
the
fix_node_constructor
branch
from
9b7f85d to
b8c11ad
Compare
|
+1 |
|
Still looks cleaner. |
dirk-thomas
added a commit
that referenced
this pull request
Jul 20, 2015
fix error handling in node constructor
mauropasse
pushed a commit
to mauropasse/rclcpp
that referenced
this pull request
Mar 29, 2021
Unlock queue mutex after taking event
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* fix bug where "wait set empty" check was wrong * clarify rcl_wait is thread-safe with unique sets * style fixup * explicitly capture const local variables this is required on Windows, but not gcc/clang
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Adapt new interface * Try to write and read rcutils_char_array_t BLOBs in sqlite * Add simple test for arbitrary char ptr * Refactor SqliteWrapper and add tests * Write and read actual timestamp from serialized message and add relative tests * Add SqliteStatementWrapper class and refactor SqliteStorage and SqliteWrapper * Refactor test fixture * ros2GH-50 Assert message content in write_integration_test, and remove TODOs * ros2GH-50 Remove sqlite_storage_plugin unit tests * ros2GH-50 Refactor SqliteStatements and SqliteStorage * ros2GH-50 Fix build after rebase * ros2GH-50 Make has_next() method no more const * ros2GH-52 Extend statement wrapper with a generic bind * ros2GH-50 Refactor after rebase * ros2GH-59 cleanup db interface - Remove virtual on methods as this was added only for unit tests. We decided to use only integration tests for the sqlite plugins. - Changes semantics of SqliteStatement: represents always a prepared statement if not null. - Ensures that a SqliteStatementWrapper cannot be copied and does not publicly expose its sqlite_stmt as this would cause memory corruption. * ros2GH-59 Introduce general read interface for sqlite statements - Uses a std::tuple for row data - Exposes an iterator interface for the query result * ros2GH-59 Cleanup: remove unused files * ros2GH-59 make sqlite interface fluent * ros2GH-59 move creation of serialized message to rosbag2_storage This is not storage plugin specific but will be needed by most (if not all) plugins. * Change rcutil_char_array_t to rmw_serialized_message_t in subscriber * Remove debugging output in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression in #51.Actually the code change is not mandatory. It only separates the rmw invocation, the error checking and the shared pointer creation with the deleter from each other.
The stacktrace is just awful anyway...