Guard against calling null goal response callback #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make sure to invoke the goal response callback before the result callback. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
CI up to test_communication:
|
dirk-thomas
approved these changes
May 24, 2019
cho3
pushed a commit
to cho3/rclcpp
that referenced
this pull request
Jun 3, 2019
Also make sure to invoke the goal response callback before the result callback. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
skucheria
pushed a commit
that referenced
this pull request
Jul 13, 2019
Also make sure to invoke the goal response callback before the result callback. Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Update CHANGELOG * 0.8.0 Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure to invoke the goal response callback before the result callback.
Addresses review comment #701 (review).